On my lord as referring to David and the possible confusion with the LORD, see the comments at verses 6 and 8.

All the good that he has spoken concerning you: see 13.14.

Prince: regarding the meaning of this term, see the comments on 9.16.

Both Revised Standard Version and Good News Translation translate this verse as a temporal relative clause leading up to verse 31. But in some languages this complex structure may need to be simplified. New Century Version makes two separate sentences of this verse and then shows the connection with what follows by beginning verse 31 with the word “then.” Verse 30 is translated “The LORD will keep all his promises of good things for you. He will make you leader over Israel.”

Quoted with permission from Omanson, Roger L. and Ellington, John E. A Handbook on the First and Second Books of Samuel, Volume 1. (UBS Helps for Translators). New York: UBS, 2001. For this and other handbooks for translators see here .