All this time (Revised Standard Version “these many days”) may refer to a period of several years. It is best translated by a phrase which refers to an indefinite but lengthy period of time.

You have never once deserted your fellow Israelites may be translated by a positive statement: “Whenever your fellow Israelites needed you, you always came to help them.”

In order to bring verses 2 and 3 closer together as a sense unit, it may be advisable to invert the order of the two sentences in verse 3. By doing so, You have been careful to obey the commands of the LORD your God would serve to reinforce the content of verse 2. As the first sentence of the verse may be rendered positively, so this sentence may be rendered negatively. The verse may then be translated, “You have never disobeyed the commands of the LORD your God, and when your fellow Israelites needed you, you always came to help them.”

Quoted with permission from Bratcher, Robert G. and Newman, Barclay M. A Handbook on Joshua. (UBS Helps for Translators). New York: UBS, 1983. For this and other handbooks for translators see here .